Difference between revisions of "IMC-Drupal/Development/Hiddens"

From Aktivix
Jump to: navigation, search
m
 
(42 intermediate revisions by the same user not shown)
Line 1: Line 1:
= Suggestions =
+
[[Category:IMC Drupal]]
  
* Add logging (system log - custom log)
+
= Download =
* Enable e-mailing of log
+
* Add filtering with custom regular expressions
+
* <del>Try using node_access instead of unpublishing for nodes</del> This would create a dramatic unnecessary overhead
+
* Add menu links at admin content and comment pages to access hiddens
+
* Hidden reason - serialised drupal variable editable?
+
* Report for hiding link - user reporting
+
* Seperate function and display make all display creating sections themeable
+
* Add no index meta tags
+
  
= Notes =
+
Now available from http://drupal.org/project/hidden
  
* _hidden_log function added
+
 
** including writing to watchdog
+
= New Features =
** writing to mail message
+
 
* _help and _menu links added
+
[[IMC-Drupal/Development/Hiddens/ScreenShots|Screenshots of Version 2]]
* _menu $may_cache sorted - non cachable links are created depending on the nodes hidden status. If not hidden there is no link for hidden item page, and no unhide, just a hide form callback. If hidden a hidden object is created and passed to view and unhide callbacks.
+
 
** /admin/settings/spam should this have the filters in it too
+
* Hidden nodes and comments are marked as hidden and have the reason for hiding displayed no matter how viewed
** /admin/content/node/list/hidden admin list of hiddens with content/node/list
+
* Admin content (node) and comment pages tabs to access and administer hiddens and reported posts
** /admin/content/comment/list/hidden admin list of hiddens with content/comment/list
+
* Hidden posts can have:
** /hidden combined listing page
+
** standard reason selected - standard reasons can be set, enabled and disabled from admin page
** /hidden/node node listing page
+
** public note - textarea for writing any public note to be displayed with the hidden post (and e-mailed if enabled)
** /hidden/comment comment listing page
+
** private note - textarea for writing any private note that will only be displayed to other users who can un/hide posts
** /hidden/node/$nid non-cachable - node display
+
* Hides are logged using system log
** /hidden/node/$nid/action non-cachable - where action is hide or unhide
+
* The log can be e-mailed (eg. to an e-mail list) item-by-item or in batches, what types of hide/unhide/action to be reported can be selected
** /hidden/comment/$cid non-cachable - comment display
+
* Adding filtering for automatic hiding
** /hidden/comment/$cid/action non-cachable - where action is hide or unhide
+
** filters can be simple text searches for word(s)
* organised required variables and settings
+
** or perl type regular expressions
* created _comment and _nodeapi hooks
+
** filters can be actioned immediately and the poster notified
** included delete, to remove from hidden system if deleted, were left in previously
+
** or delayed for a period set by admin and hidden after publishing
** ready to hook into filter
+
** using public private note system public note goes to article (and e-mail if enabled) but there can also be a hidden note about the filter
** moved reformatting of hidden content into hook $op view (and for node also alter). Title no longer needs changing in DB. Hidden information displayed in other not /hidden/... views (admin user looking at pages sees unpublished material).
+
* Report for hiding link - user reporting
* created _hidden_mail to send e-mail notices
+
** admin page to allow hiding or marking as seen user reported pages. Easily sortable. You can give hide privileges to users without giving other admin privs so someone who is making good reports can be given the easy route into helping admin the site.
* created _cron hook for periodic e-mailing
+
* Hides, reported hides, and checks on reported hides have user information with them.
* made _link hook themeable
+
* All display creating sections are themeable.
* made hide form themeable
+
* 'No-index' meta tags added to hidden pages.
* removed _update hook as hidden isn't a node type
+
* <del>Try using node_access instead of unpublishing for nodes</del> <em>This would create a dramatic unnecessary overhead</em>
* altered _hidden_is_hidden to ($type, $id) now returns a hidden object or false
+
* Integrates with spam.module
* updated db query functions insert works with ($type, $nid, $cid, $reason) delete works with ($type, $id)
+
 
* reason now filtered by drupal check_markup() filter
+
[[IMC-Drupal/Development/Hiddens/VersionTwoNotes|Notes from the development of Version 2]]
* changed _hidden_check_nan() to _hidden_check_params() this now only needs to only be called by the hide form processing functions, at also sanity checks against type of content now. Other functions are using drupal menu item creation and _hidden_is_hidden() validation.
+
* Hidden display list functions altered/created
+
** hidden_list_nodes and theme_hidden_list_nodes - now using themeable table - title, user, reason listed
+
** hidden_admin_list_nodes and theme_hidden_admin_list_nodes - new with additional info (date...) and sorting capabilities to the public user lists
+
** hidden_list_comments and theme_hidden_list_comments - as nodes above
+
** hidden_admin_list_comments and theme_hidden_admin_list_comments - as nodes above, not this is the only place mass operations can be added in for comments
+
* removing hard coded drupal goto's from reusable functions, should handled by calling function depending on where they come from - returning to node/comment is probably a desirable option in many cases
+
  
 
== TODO ==
 
== TODO ==
  
 
Notes in code plus:
 
Notes in code plus:
* upgrade script
+
* remove HIDDEN: from titles of already nodes/comments - should be handled by _node _comment hooks $op=view
** remove HIDDEN: from titles of already nodes/comments - should be handled by _node _comment hooks $op=view
+
* check consistent use of objects for forms
 +
 
 +
To fix?
 +
 
 +
* What's the db length for notices, should it be? <<<<< What was this?
 +
 
 +
= Feature requests =
 +
 
 +
Probably not going to be put into the first release of this version, but maybe needed:
 +
 
 +
* edit hidden - the ability to edit the hidden reasons (without hiding and rehiding) - issues with user logging now resolved, hidden admin users can set the user hiding others cannot
 +
* view reported hidden - the ability to view the hidden request. It's being e-mailed and you can see the standard reason in the table, but not implemented a view to see the public and private reasons given from admin.
 +
* use node and comment modules to better effect - only thing left here is probably edit hidden, put the hidden reason in an edit form - there are comments in the code where to hook this in
 +
* additional spam module integration - it would be nice to have just one 'report' link and one form. The spam module report form and sumit functions are tied to the contents of the url, this makes it a bit more difficult.
 +
* be able to comment on hidden nodes. "not being able to is a feature" - ekes
  
== Thoughts ==
+
= Drupal 6 upgrade =
  
* filter delay timing
+
[[IMC-Drupal/Development/Hiddens/Drupal6|Working notepad for module changes for Drupal 6]]
* use node and comment modules to better effect, also view in hooks - we can get to the object before and edit it if we are calling it, we can still edit it's view even if admin are viewing it
+

Latest revision as of 16:02, 12 September 2007


Download

Now available from http://drupal.org/project/hidden


New Features

Screenshots of Version 2

  • Hidden nodes and comments are marked as hidden and have the reason for hiding displayed no matter how viewed
  • Admin content (node) and comment pages tabs to access and administer hiddens and reported posts
  • Hidden posts can have:
    • standard reason selected - standard reasons can be set, enabled and disabled from admin page
    • public note - textarea for writing any public note to be displayed with the hidden post (and e-mailed if enabled)
    • private note - textarea for writing any private note that will only be displayed to other users who can un/hide posts
  • Hides are logged using system log
  • The log can be e-mailed (eg. to an e-mail list) item-by-item or in batches, what types of hide/unhide/action to be reported can be selected
  • Adding filtering for automatic hiding
    • filters can be simple text searches for word(s)
    • or perl type regular expressions
    • filters can be actioned immediately and the poster notified
    • or delayed for a period set by admin and hidden after publishing
    • using public private note system public note goes to article (and e-mail if enabled) but there can also be a hidden note about the filter
  • Report for hiding link - user reporting
    • admin page to allow hiding or marking as seen user reported pages. Easily sortable. You can give hide privileges to users without giving other admin privs so someone who is making good reports can be given the easy route into helping admin the site.
  • Hides, reported hides, and checks on reported hides have user information with them.
  • All display creating sections are themeable.
  • 'No-index' meta tags added to hidden pages.
  • Try using node_access instead of unpublishing for nodes This would create a dramatic unnecessary overhead
  • Integrates with spam.module

Notes from the development of Version 2

TODO

Notes in code plus:

  • remove HIDDEN: from titles of already nodes/comments - should be handled by _node _comment hooks $op=view
  • check consistent use of objects for forms

To fix?

  • What's the db length for notices, should it be? <<<<< What was this?

Feature requests

Probably not going to be put into the first release of this version, but maybe needed:

  • edit hidden - the ability to edit the hidden reasons (without hiding and rehiding) - issues with user logging now resolved, hidden admin users can set the user hiding others cannot
  • view reported hidden - the ability to view the hidden request. It's being e-mailed and you can see the standard reason in the table, but not implemented a view to see the public and private reasons given from admin.
  • use node and comment modules to better effect - only thing left here is probably edit hidden, put the hidden reason in an edit form - there are comments in the code where to hook this in
  • additional spam module integration - it would be nice to have just one 'report' link and one form. The spam module report form and sumit functions are tied to the contents of the url, this makes it a bit more difficult.
  • be able to comment on hidden nodes. "not being able to is a feature" - ekes

Drupal 6 upgrade

Working notepad for module changes for Drupal 6